-
-
Notifications
You must be signed in to change notification settings - Fork 480
LONDON 10 - Hamda Abdi- JS-CORE-1 - WEEK 1 #529
base: master
Are you sure you want to change the base?
Conversation
I fixed all the syntax error.
I solved the error. I used a quote '' INSTEAD of backtick ``
kjjwhitlock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good, Hamda. I like how you have chosen clear labelnames and have paid attention to ensure correct spacing and formatting. Keep it up.
|
|
||
| function addNumbers(a b c) { | ||
| function addNumbers(a, b, c) { | ||
| return a + b + c; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
| function introduceMe(name, age) | ||
| return `Hello, my {name}` is "and I am $age years old`; | ||
| function introduceMe(name, age) { | ||
| return `Hello, my name is ${name} and I am ${age} years old`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
| total = a + b; | ||
|
|
||
| return "The total is total"; | ||
| return `The total is ${total}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good
| function multiply(a, b, c) { | ||
| a * b * c; | ||
| return; | ||
| return a * b * c; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and tidy, like it
| @@ -1,16 +1,18 @@ | |||
| // Add comments to explain what this function does. You're meant to use Google! | |||
| function getRandomNumber() { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the comment here to explain what this does?
| } | ||
| //It gives random number between 0 to 10. | ||
|
|
||
| // Add comments to explain what this function does. You're meant to use Google! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here too...
| function concatenate(firstword, secondword, thirdword) { | ||
| // Write the body of this function to concatenate three words together. | ||
| // Look at the test case below to understand what this function is expected to return. | ||
| return `${firstword} ${secondword} ${thirdword}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice use of string interpolation
|
|
||
| function calculateSalesTax() {} | ||
| function calculateSalesTax(sales) { | ||
| const tax = 0.2 * sales; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, clear labelling
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?